Repository navigation
fix: bump vulnerable transitive dependencies - #91
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
#88, #87 and #81 each bump one vulnerable transitive dependency, and each changes nothing but
package-lock.json. Merging them in sequence forces a rebase of the other two every time, and #85/#84 already showed where that goes: merging #86 closed both and Dependabot reopened them at newer versions as #88 (2.11.22→2.11.24) and #87 (4.28.9→4.29.0). This resolves all three advisories in one lockfile change instead.browserslistbaseline-browser-mapping@humanfs/nodeAll three are transitive — none of them appear in
package.json:Every patched version already falls inside those parent ranges, so
npm updatereaches them on its own. Nopackage.jsonchange and nooverridesentry is needed.Neither #86 nor #90 covered these. #86 did close the
sharpadvisory as a side effect of regenerating the lockfile, so #90 was checked for the same: its lockfile leaves all three at the vulnerable versions, becausenext16.3.5 still requestsbaseline-browser-mapping: ^2.9.19.Why the lockfile shows nine entries, not three
npm updatealso moves the children of the three packages. These are cascading updates inside ranges that already existed, not widened scope:package-lock.jsonis the only changed file.Related Issue
No issue. Supersedes #88, #87 and #81 — close them once this merges, if Dependabot has not already.
How to Verify
Run from a clean checkout of
main:Apply the update:
Confirm the three targets reached their patched versions:
Confirm nothing outside the lockfile moved:
Match CI (
npm ci-> format:check -> lint -> typecheck -> build):npm auditreportsfound 0 vulnerabilities.After merge, check Security -> Dependabot alerts: the
browserslist,baseline-browser-mappingand@humanfs/nodeadvisories should all move to fixed, leaving no open alerts.Checklist
feat:,fix:,chore:,refactor:,docs:,i18n:)locales/ko.jsonandlocales/en.json(if UI text changed) — N/A, no UI text changed