Repository navigation
fix(nara): --objects downloads scans served from catalog.archives.gov/medialive - #110
Merged
Merged
Conversation
The live API links digital objects on the catalog host itself, so the S3-only allowlist refused every file. The notice now names real hosts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wdqj51cPquyTRKmoJLQV6y
This was referenced Oct 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live run with a real NARA key:
records fetch 17400884 -s nara --objectsskipped all 20 files as "not NARA's object storage". The live API links scans underhttps://catalog.archives.gov/medialive/(served by NARA, HTTP 200, no redirect), and the allowlist only accepted the S3 buckets.https://catalog.archives.gov/medialive/..., rejecting http,..segments, other catalog paths and look-alike hosts (tests added first, failed, then pass).Live proof with the fix: 20 of 20 ingested in about 70s; OCR text reads "Freedom of Information Act Guide & Privacy Act Overview September 1992 Edition"; a rerun reports 20 already present. Full suite: 526 passed, 20 skipped.
馃 Generated with Claude Code
https://claude.ai/code/session_01Wdqj51cPquyTRKmoJLQV6y