Adjust to upcoming Base Vararg change - #843
Conversation
There's two changes here: 1. Drop unnecessary `<:` in Vararg. Tuples are already covariant and this form will be deprecated. 2. Use Base.unwrapva, rather than open coding the equivalent, since the implementation will change.
|
@mateuszbaran @c42f @andyferris If this looks good, could I get it merged/tagged? I'd like to run PkgEval on my Base change, but of course a lot of packages depend on StaticArrays, so won't get tested without this. |
|
I think it looks fine and can be merged. Tagging is a bit of an issue though because master currently has a few slightly breaking changes and we may need to tag a breaking release. |
That means a PkgEval won't be possible soon anyway since it will take time for all the ecosystem to upgrade... What are the changes? Are they truly BREAKING or are they "technically breaking"? This will be extremely disruptive. |
|
Perhaps try running a PkgEval with the StaticArrays master vs the latest StaticArray release and see what the results are. |
|
Hmm? 0.12.5 was tagged from master two days ago and is the latest commit. Am I missing something? |
|
Oh, I see. It wasn't merged. |
|
I'll leave it to the maintainers, but if the next release would be a while, it'd be great if we could tag an 0.12.5 that's just 0.12.4 + this commit, such that the Base PR can move forward. |
Nothing truly major. I think the biggest change is #783 that slightly changed how Given how few packages actually use |
|
@c42f what if we release 0.13.0 under the premise of it being a “release candidate” for 1.0.0? |
|
If the next release won't be a patch release, then I'd still like to request a 0.12.5 as 0.12.4 + this patch, so existing tagged packages with compat upper bounds on 0.12 will pick up this change. |
|
I see. Sounds like we'll have to do something, then. It's not to hard too backport a few bugfixes.
Aww, Keno, I kinda thought you were a maintainer ;) |
|
I'm pretty sure I used to have access to this repo, but that got dropped in one of the many rounds of access reshuffle ;). That's ok though. My evil plan as always been to make this package unnecessary one day, so I'll just wait until then. |
|
OK I just re-invited you. I kinda think of you as our I also created a release-0.12 branch, with just a couple of very conservative cherry-picks.
My hope and dream, too. |
|
This seems to be pointing to the new branch now. I suspect this will be automatic. JuliaRegistries/General#23652 |
|
Thanks @andyferris |
Perfect, you beat me to it.
Haha, yes indeed. |
6 participants
There's two changes here:
<:in Vararg. Tuples are already covariant and this form will be deprecated.With this change, everything should work with or without JuliaLang/julia#38136.