Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 99.79% 99.82% +0.03%
==========================================
Files 1 1
Lines 479 583 +104
==========================================
+ Hits 478 582 +104
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @braingram, thanks for meeting with us today! I've started collecting my disorganized notes from office hours here. Please feel free to add/modify the to-do list above. I'll see if I can give you collaborator access too |
f512166 to
03cfeed
Compare
|
Okie doke, things look to be working alright for the test files I've been working with, including for Roman Level 3 data products like this one. I've organized changes into the 6 self-contained commits summarized in the PR description. Do folks see any remaining issues that should be addressed here before making our first v2 release? @eschnett @braingram @cgarling |
|
I'm afraid I don't really have time to give you a review on this, but I love seeing the progress! |
|
Thanks for putting this together! Testing it with a roman level 2 (cal) file, reading it in and writing it back out with: af = load("data/r0000101001001001001_0001_wfi01_f158_cal.asdf"; extensions=true, validate_checksum=false)
save("foo.asdf", af)Attempting to read the file into the python asdf implementation fails for a few reasons:
spatial_x: -5.204446308234682e7loads in as a string instead of a float. I'm not familiar enough with julia to propose a fix but what would be needed to add a sign before the |
|
This is awesome, thanks for the quick feedback, Brett!
Ah, I see that my tag handling was too narrow (was only handling custom/unknown tags). I've opened it up to preserve other tags too now (2736a52)
Roger, I've changed the behavior to automatically bump all instances of This seemed like the most straightforward approach to me, but I think I am seeing that the python impl actually keeps existing
oof, that is a def a sharp edge, thanks for pointing this out. I'll sit down and give this some thought tomorrow to make sure I follow the spec. Thanks for the link!
Just to make sure I am following, did you mean putting the sign after the |
|
Thanks for fixing my mistake on the scientific notation format. I updated the comment above. |
|
That was an interesting rabbit hole. I think I have a fix in place for the scientific notation now (adcfa53) I've added some of the lore as comments in the source file for future me / other maintainers, but the basic summary IIUC is:
I went with Option |
|
Yeah from a design perspective I like extending |
|
Thanks! I just testing this with 2 example roman L2 and L3 files and I'm able to:
Excellent work! It's exciting to see this library so far along. |
|
Thanks, Brett! I've added a couple more bookkeeping thing like a very brief Python <--> Julia interop page and a little bit of clean up on our tree display I'll give things another week to settle / receive any more feedback from folks before getting this merged |
Final polish for v2 release based on notes from 05 Jun 2026 office hour:
build: Update ASDF standard 1.2.0 --> 1.6.0fix: Don't print empty block lists to filefix: Typo asdf/library --> asdf_libraryfix: Warn + preserve unknown tagsfeat: Materialize ucs4/ascii array data as string viewsfix: Catch ndarray version + float16 incompatibilityTry this PR
Install Julia: https://julialang.org/downloads/
Create a new environment:
Install this branch:
Load a sample asdf file:
Sample asdf files are available here.
Documentation preview: https://juliaastro.org/ASDF.jl/previews/PR40/