Repository navigation
Conversation
`write(io, ::DataString)` copied one byte per call. A view's content is one contiguous run of its retained buffer, so write it with a single `unsafe_write`. `print`, interpolation, and `string` all go through this method; writing 13-40 byte strings to an IOBuffer is about 4.5x faster. Inline strings keep the byte loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write(io, ::DataString)wrote one byte per call. A view's content is one contiguous run of its retained buffer, so this writes it with a singleunsafe_write. Inline strings (12 bytes or fewer) keep the byte loop, which measured the same as a block write.print, string interpolation, andstringall go through this method.Writing 10,000 view strings of 13-40 bytes to an
IOBuffer(Chairmarks, Julia 1.12.6, same process, interleaved, three rounds): 1.10-1.31 ms before, 0.23-0.27 ms after (about 4.5x). With anIOStream, each per-bytewritealso takes the stream lock, so the gap is larger there.Verification:
Pkg.test()passes on Julia 1.10.11 and 1.12.6.🤖 Generated with Claude Code