AcceleratedKernels accumulate and sort - #423
Open
michel2323 wants to merge 3 commits into
Open
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 81.17% 80.57% -0.61%
==========================================
Files 13 15 +2
Lines 935 942 +7
==========================================
Hits 759 759
- Misses 176 183 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+1
to
+3
| # Use a smaller block size to work around a scan correctness issue | ||
| # with the Blelloch parallel prefix sum at larger block sizes (>=128). | ||
| const _ACCUMULATE_BLOCK_SIZE = 64 |
Member
There was a problem hiding this comment.
Can you expand on this? Is this a general AK issue or specific to OpenCL? Does this not depend on the workgroup/subgroup size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds accumulate and sort through AcceleratedKernels.jl to be on par with CUDA.jl, AMDGPU.jl, and oneAPI.jl.