Detect ParallelTestRunner's failure-handling options instead of versioning them - #606
Merged
Conversation
…oning them The `recycle_on_failure` and `retries` options were gated on `pkgversion(ParallelTestRunner) >= v"2.7.0"`, betting that ParallelTestRunner#148 would land in that release. It did not -- that PR is still open -- so once 2.7.0 hit the registry the guard started passing keyword arguments the released `runtests` does not accept, and every CI job failed with a MethodError before running a single test. Detect the keywords via `Base.kwarg_decl` instead. That is correct against both the registered releases and a development checkout carrying the PR, and it does not need updating when the options eventually ship.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 7.21% 78.64% +71.42%
==========================================
Files 50 50
Lines 3452 3488 +36
==========================================
+ Hits 249 2743 +2494
+ Misses 3203 745 -2458 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christiangnrd
approved these changes
Aug 5, 2026
christiangnrd
left a comment
christiangnrd
left a comment
Member
There was a problem hiding this comment.
kwarg_decl isn't public but this is better than broken tests (here and over at GPUArrays) until JuliaTesting/ParallelTestRunner.jl#148 is finalized.
Member
That should have been a revert? Anyway, let's merge this to unblock CI, but this code is ugly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.