Skip to content

Detect ParallelTestRunner's failure-handling options instead of versioning them #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Aug 6, 2026
+4 −1
Merged

Detect ParallelTestRunner's failure-handling options instead of versioning them #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ end
# On memory-pressured GPUs (e.g. 8GB cards) a failing test can leave the worker — or even
# the driver — in a state where every subsequent allocation fails, so recycle workers on
# failure and give failed files one exclusive retry on an otherwise-idle device.
failure_handling = if pkgversion(ParallelTestRunner) >= v"2.7.0"
# These options are not available in every ParallelTestRunner release, so detect them
# rather than gating on a version number.
runtests_kwargs = Set(Iterators.flatten(Base.kwarg_decl.(methods(ParallelTestRunner.runtests))))
failure_handling = if :recycle_on_failure in runtests_kwargs
(; recycle_on_failure = true, retries = 1)
else
(;)
Expand Down
Loading