feat: add support for custom lock manager instance#118
Open
niksy wants to merge 1 commit intoJulien-R44:mainfrom
Open
feat: add support for custom lock manager instance#118niksy wants to merge 1 commit intoJulien-R44:mainfrom
niksy wants to merge 1 commit intoJulien-R44:mainfrom
Conversation
|
60afbf0 to
35bf9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for passing custom lock manager instance via
lockManageroption (same style as logger injection).This allows setting custom locks implementation such as Redis distributed locks.
The problem I see is that all Redis distributed locks implementations have async release functions while async-mutex uses sync function. This also means that we should change internal API to support this use case.
I’m going to make all the necessary changes but I wanted to see if this is the correct approach for this feature.