Skip to content

ci(contracts): ensure rustfmt is installed so the fmt gate actually runs - #1423

Merged
Junirezz merged 2 commits into
Junirezz:mainfrom
broda-spendy:fix/1302-fmt-gate
Sep 28, 2026
Merged

Junirezz merged 2 commits into
Junirezz:mainfrom
broda-spendy:fix/1302-fmt-gate

Conversation

@broda-spendy

Copy link
Copy Markdown
Contributor

Closes #1302

The rust-test job in rust-wasm.yml already runs cargo fmt --all -- --check, but installs the toolchain with profile minimal plus only the clippy component, so cargo fmt fails with missing-component instead of gating on formatting. This adds rustfmt to the installed components and applies the outstanding cargo fmt reformatting to bridge-compat (whitespace-only, produced by cargo fmt itself).

Deliberately out of scope (covered by sibling PRs, verified not duplicated via git log and gh pr list):

Verification (Windows, cargo +stable-x86_64-pc-windows-gnu, GNU toolchain):

  • Before (upstream/main): cargo fmt --all -- --check exits 1 with bridge-compat drift plus vault lib.rs:1375 mismatched-delimiter parse error.
  • After: cargo fmt -p bridge-compat -- --check exits 0; cargo fmt --all -- --check now fails only on the vault parse error owned by fix(contracts): restore compilation across all four contract crates #1416.
  • No overlap: git diff -w on bridge-compat shows layout-only changes; rust-wasm.yml diff is the single components line plus comment.

The rust-test job installs the toolchain with profile minimal and only
the clippy component, so cargo fmt --all -- --check fails with
'no such command' instead of gating on formatting. Install rustfmt too.

Also applies the outstanding cargo fmt reformatting to bridge-compat.
The remaining --all --check failure (vault lib.rs delimiter mismatch)
is the merge corruption restored by the fix/1303-rust-merge-corruption
branch and intentionally left for that PR.

Closes Junirezz#1302
@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@broda-spendy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Junirezz
Junirezz marked this pull request as ready for review September 28, 2026 09:54
@Junirezz
Junirezz merged commit d58e143 into Junirezz:main Sep 28, 2026
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo fmt must pass on all Rust contracts before merge

2 participants