fix: pin vault metadata to IPFS and track pin lifecycle - #1504
Open
bluegate916 wants to merge 1 commit into
Open
bluegate916 wants to merge 1 commit into
bluegate916 wants to merge 1 commit into
Conversation
|
@bluegate916 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a gap where
backend/src/services/metadata.tsuploadedvault.jsonto IPFS viaipfs.addwithout pinning, causing the block to be garbage-collected after ~12h. As a result,GET /vaults/:id/metadatareturned 504 gateway errors, frontend vault icons broke after a day, andvault.metadataURIbecame permanently unresolvable.The fix pins the CID immediately after upload, persists a
pinnedAttimestamp, unpins on vault delete, and adds an admin endpoint to surface stale unpinned CIDs.Related Issue
Changes
📌 Metadata Pinning
[MODIFY]
backend/src/services/metadata.tsipfs.add, callipfs.pin.add(cid)with the returned CID.pinnedAton the vault metadata record.unpincall on vault delete to release the pin.[MODIFY]
backend/prisma/schema.prismapinnedAtfield to the vault metadata model to record when the CID was pinned.[ADD]
backend/src/__tests__/metadataPinning.test.tsipfs.addto return a CID, assertipfs.pin.addis called with the same CID, and assert the DB row haspinnedAtset.Verification Results
ipfs.add, callipfs.pin.add(cid)and persistpinnedAttimestamp; addunpinon vault deletepinnedAtpersisted, unpin wired to vault deleteGET /admin/metadata/pinsto list unpinned CIDs older than 24hpinnedAtmetadataPinning.test.tsCloses #1449