Skip to content

Potential fix for 1 code quality finding #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utkarsh232005 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

Potential fix for 1 code quality finding #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/docker/containers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,19 @@ const calculateMemoryUsage = (memoryStats: any): number => {
return usage;
};

type DebugLogger = {
debug: (message: string) => void;
};

const hasDebugLogger = (value: unknown): value is DebugLogger => {
return (
typeof value === 'object' &&
value !== null &&
'debug' in value &&
typeof (value as { debug?: unknown }).debug === 'function'
);
};

/**
* Fetches stats for a single container.
* @param docker The Dockerode client.
Expand All @@ -134,8 +147,8 @@ const fetchContainerStats = async (docker: any, containerId: string) => {
} catch (err) {
const errMsg = err instanceof Error ? err.message : String(err);
const msg = `Failed to fetch stats for container ${containerId}: ${errMsg}`;
if (typeof (logger as any).debug === 'function') {
(logger as any).debug(msg);
if (hasDebugLogger(logger)) {
logger.debug(msg);
} else {
console.debug(msg);
}
Expand Down
Loading