Skip to content

Potential fix for 1 code quality finding #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utkarsh232005 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Potential fix for 1 code quality finding #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const handleConfig = (res: any): void => {
* @param res The HTTP response object.
* @param options Server configuration options.
*/
export const routeRequest = (req: any, res: any, options: ServerOptions): void => {
export const routeRequest = async (req: any, res: any, options: ServerOptions): Promise<void> => {
const url = req.url ?? '';
const method = req.method ?? 'GET';

Expand All @@ -132,7 +132,7 @@ export const routeRequest = (req: any, res: any, options: ServerOptions): void =
}

if (method === 'POST' && url === '/analyze') {
handleAnalyze(req, res, options);
await handleAnalyze(req, res, options);
return;
}

Expand All @@ -148,8 +148,12 @@ export const routeRequest = (req: any, res: any, options: ServerOptions): void =
export async function createServer(options: ServerOptions): Promise<{ close: () => void; port: number }> {
const { createServer: createHttpServer } = await import('node:http');

const server = createHttpServer((req, res) => {
routeRequest(req, res, options);
const server = createHttpServer(async (req, res) => {
try {
await routeRequest(req, res, options);
} catch (error) {
sendJson(res, 500, { error: (error as Error).message });
}
});

return new Promise((resolve) => {
Expand Down
Loading