fix(benchmarks): handle EOF when selecting models without -m#1013
Open
sridipbasu wants to merge 1 commit into
Open
fix(benchmarks): handle EOF when selecting models without -m#1013sridipbasu wants to merge 1 commit into
sridipbasu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle
EOFErrorduring interactive benchmark model selection to improve behavior in non-interactive environments.Previously, running:
without
-m/--modelcould fail ambiguously or hang when stdin was unavailable (for example in CI or other non-interactive environments).This change:
input()call intry/except EOFErrorValueErrorinstructing users to pass-m/--modelecho 1 | ...)Changes
Updated
_select_models_interactivelyinkaggle_api_extended.pyAdded tests for:
Test Plan