Skip to content

Enable runtime-async on all libraries #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaliumhexacyanoferrat merged 6 commits into from
Sep 2, 2026
Merged

Enable runtime-async on all libraries #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1727482
Enable runtime-async on all libraries
Kaliumhexacyanoferrat Sep 2, 2026
d68d901
Remove no longer needed warning supressions
Kaliumhexacyanoferrat Sep 2, 2026
9620563
Opt out of runtime-async for UnwrapAsync()
Kaliumhexacyanoferrat Sep 2, 2026
7db74a1
Update nuget packages
Kaliumhexacyanoferrat Sep 2, 2026
573b174
Set the analyzer to 5.8 to be able to build again
Kaliumhexacyanoferrat Sep 2, 2026
3bcf497
Back to old references
Kaliumhexacyanoferrat Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion API/GenHTTP.Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<ProjectReference Include="..\Generators\MemoryView\GenHTTP.Generators.MemoryView.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />

<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.11" />

</ItemGroup>

Expand Down
6 changes: 4 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

<TargetFrameworks>net10.0;net11.0</TargetFrameworks>

<Features Condition="'$(TargetFramework)' == 'net11.0'">$(Features);runtime-async=on</Features>

<LangVersion>14.0</LangVersion>
<Nullable>enable</Nullable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Expand All @@ -28,7 +30,7 @@
<Deterministic>true</Deterministic>

<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>CS1591,CS1587,CS1572,CS1573,NU1510</NoWarn>
<NoWarn>CS1591,CS1572,CS1573</NoWarn>

</PropertyGroup>

Expand All @@ -40,7 +42,7 @@

<ItemGroup>

<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.301" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.400" PrivateAssets="All" />

</ItemGroup>

Expand Down
4 changes: 2 additions & 2 deletions Engine/Internal/GenHTTP.Engine.Internal.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

<ProjectReference Include="..\..\Modules\IO\GenHTTP.Modules.IO.csproj" />

<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="10.0.11" />

<PackageReference Include="Glyph11" Version="0.3.6" />
<PackageReference Include="Glyph11" Version="0.3.7" />

</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Engine/Ioxide/GenHTTP.Engine.Ioxide.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<ProjectReference Include="..\Shared\GenHTTP.Engine.Shared.csproj" />
<PackageReference Include="ioxide" Version="0.1.1" />
<PackageReference Include="ioxide.tls" Version="0.1.1" />
<PackageReference Include="Glyph11" Version="0.3.6" />
<PackageReference Include="Glyph11" Version="0.3.7" />
<!-- Parallel parse path for benchmarking — GENHTTP_IOXIDE_PARSER=pico (see ConnectionDriver). -->
<PackageReference Include="Glyph11.Pico" Version="0.0.1" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions Engine/Shared/GenHTTP.Engine.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

<ProjectReference Include="..\..\Modules\ErrorHandling\GenHTTP.Modules.ErrorHandling.csproj" />

<PackageReference Include="Glyph11" Version="0.3.6" />
<PackageReference Include="Glyph11" Version="0.3.7" />

<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.11" />

</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Modules/Archives/GenHTTP.Modules.Archives.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<ProjectReference Include="..\IO\GenHTTP.Modules.IO.csproj" />

<PackageReference Include="SharpCompress" Version="0.50.1" />
<PackageReference Include="SharpCompress" Version="0.50.4" />

</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Modules/DependencyInjection/GenHTTP.Modules.DependencyInjection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.11" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Modules/Protobuf/GenHTTP.Modules.Protobuf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<ProjectReference Include="..\Conversion\GenHTTP.Modules.Conversion.csproj" />

<PackageReference Include="protobuf-net" Version="3.2.56" />
<PackageReference Include="protobuf-net" Version="3.4.21" />

</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Modules/Reflection/GenHTTP.Modules.Reflection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ProjectReference Include="..\Conversion\GenHTTP.Modules.Conversion.csproj" />
<ProjectReference Include="..\Pages\GenHTTP.Modules.Pages.csproj" />

<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="5.6.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="5.9.0" />

<ProjectReference Include="..\..\Generators\MemoryView\GenHTTP.Generators.MemoryView.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />

Expand Down
4 changes: 3 additions & 1 deletion Modules/Reflection/MethodHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Reflection;
using System.Runtime.ExceptionServices;
using System.Runtime.CompilerServices;

using Cottle;

Expand Down Expand Up @@ -235,7 +236,8 @@ public ValueTask PrepareAsync(IServer server)
throw;
}
}


[RuntimeAsyncMethodGenerationAttribute(false)]
private static async ValueTask<object?> UnwrapAsync(object? result)
{
if (result == null)
Expand Down
31 changes: 31 additions & 0 deletions Modules/Reflection/RuntimeAsyncMethodGenerationAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// ReSharper disable once CheckNamespace
namespace System.Runtime.CompilerServices;

/// <summary>
/// Controls whether runtime-generated async code is used for an async method.
/// </summary>
[AttributeUsage(AttributeTargets.Method, Inherited = false)]
public sealed class RuntimeAsyncMethodGenerationAttribute : Attribute
{

/// <summary>
/// Initializes a new instance of the <see cref="RuntimeAsyncMethodGenerationAttribute"/> class.
/// </summary>
/// <param name="enabled">
/// <c>true</c> to enable runtime async generation for the attributed method;
/// <c>false</c> to disable it.
/// </param>
public RuntimeAsyncMethodGenerationAttribute(bool enabled)
{
Enabled = enabled;
}

/// <summary>
/// Gets whether runtime async generation is enabled.
/// </summary>
public bool Enabled { get; }

}
16 changes: 8 additions & 8 deletions Testing/Acceptance/GenHTTP.Testing.Acceptance.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,20 @@

<ItemGroup>

<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="5.6.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="5.9.0" />

<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.11" />

<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.10" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.11" />

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.8.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />

<PackageReference Include="Microsoft.OpenApi" Version="3.9.0" />
<PackageReference Include="Microsoft.OpenApi.YamlReader" Version="3.9.0" />
<PackageReference Include="Microsoft.OpenApi" Version="3.10.2" />
<PackageReference Include="Microsoft.OpenApi.YamlReader" Version="3.10.2" />

<PackageReference Include="MSTest" Version="4.3.3" />

<PackageReference Include="NSubstitute" Version="6.0.0" />
<PackageReference Include="NSubstitute" Version="6.2.0" />

<PackageReference Include="coverlet.collector" Version="10.0.1">
<PrivateAssets>all</PrivateAssets>
Expand All @@ -66,7 +66,7 @@

<PackageReference Include="Websocket.Client" Version="5.5.0" />

<PackageReference Update="Microsoft.SourceLink.GitHub" Version="10.0.301" />
<PackageReference Update="Microsoft.SourceLink.GitHub" Version="10.0.400" />

</ItemGroup>

Expand Down
Loading