Skip to content

Fix late Facebook feature selection #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kapusch merged 1 commit into from
Jul 15, 2026
Merged

Fix late Facebook feature selection #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ jobs:
with:
dotnet-version: "10.0.x"

- name: Validate feature selection
run: bash tests/validate-feature-selection.sh

- uses: actions/setup-java@v4
with:
distribution: "microsoft"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ jobs:
with:
dotnet-version: "10.0.x"

- name: Validate feature selection
run: bash tests/validate-feature-selection.sh

- uses: actions/setup-java@v4
with:
distribution: "microsoft"
Expand Down
3 changes: 0 additions & 3 deletions src/Kapusch.FacebookApisForAndroidComponents/buildTransitive/Kapusch.Facebook.Android.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<Project>
<PropertyGroup>
<KapuschFacebookFeatures Condition="'$(KapuschFacebookFeatures)' == ''">Login</KapuschFacebookFeatures>
<_KapuschFacebookFeaturesDelimited>;$([System.String]::Copy('$(KapuschFacebookFeatures)').Replace(' ', ''));</_KapuschFacebookFeaturesDelimited>
<_KapuschFacebookLoginEnabled>$([System.String]::Copy('$(_KapuschFacebookFeaturesDelimited)').Contains(';Login;'))</_KapuschFacebookLoginEnabled>
<_KapuschFacebookShareEnabled>$([System.String]::Copy('$(_KapuschFacebookFeaturesDelimited)').Contains(';Share;'))</_KapuschFacebookShareEnabled>
<DisableKapuschFacebookAndroidNativeAssets Condition="'$(DisableKapuschFacebookAndroidNativeAssets)' == ''">false</DisableKapuschFacebookAndroidNativeAssets>
<UseKapuschFacebookAndroidInteropFromSource Condition="'$(UseKapuschFacebookAndroidInteropFromSource)' == ''">false</UseKapuschFacebookAndroidInteropFromSource>
</PropertyGroup>
Expand Down
5 changes: 5 additions & 0 deletions ...Kapusch.FacebookApisForAndroidComponents/buildTransitive/Kapusch.Facebook.Android.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
<Project>
<PropertyGroup>
<!-- Package .props are imported before the consuming project body. Resolve the
selected features here, after the consumer had a chance to override them. -->
<_KapuschFacebookFeaturesDelimited>;$([System.String]::Copy('$(KapuschFacebookFeatures)').Replace(' ', ''));</_KapuschFacebookFeaturesDelimited>
<_KapuschFacebookLoginEnabled>$([System.String]::Copy('$(_KapuschFacebookFeaturesDelimited)').Contains(';Login;'))</_KapuschFacebookLoginEnabled>
<_KapuschFacebookShareEnabled>$([System.String]::Copy('$(_KapuschFacebookFeaturesDelimited)').Contains(';Share;'))</_KapuschFacebookShareEnabled>
<_KapuschFacebookAndroidPackageRoot>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)..'))</_KapuschFacebookAndroidPackageRoot>
</PropertyGroup>

Expand Down
21 changes: 21 additions & 0 deletions tests/FeatureSelection.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<Project>
<!-- Reproduce NuGet's import order: .props, consumer project body, .targets. -->
<Import Project="../src/Kapusch.FacebookApisForAndroidComponents/buildTransitive/Kapusch.Facebook.Android.props" />

<PropertyGroup Condition="'$(RequestedFacebookFeatures)' != ''">
<KapuschFacebookFeatures>$(RequestedFacebookFeatures)</KapuschFacebookFeatures>
</PropertyGroup>

<Import Project="../src/Kapusch.FacebookApisForAndroidComponents/buildTransitive/Kapusch.Facebook.Android.targets" />

<Target Name="ValidateFeatureSelection">
<Error
Condition="'$(_KapuschFacebookLoginEnabled)' != '$(ExpectedLoginEnabled)'"
Text="Expected Login=$(ExpectedLoginEnabled), got $(_KapuschFacebookLoginEnabled) for '$(KapuschFacebookFeatures)'."
/>
<Error
Condition="'$(_KapuschFacebookShareEnabled)' != '$(ExpectedShareEnabled)'"
Text="Expected Share=$(ExpectedShareEnabled), got $(_KapuschFacebookShareEnabled) for '$(KapuschFacebookFeatures)'."
/>
</Target>
</Project>
11 changes: 11 additions & 0 deletions tests/validate-feature-selection.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env bash

set -euo pipefail

project="tests/FeatureSelection.proj"

dotnet msbuild "$project" -t:ValidateFeatureSelection -p:ExpectedLoginEnabled=True -p:ExpectedShareEnabled=False

dotnet msbuild "$project" -t:ValidateFeatureSelection -p:RequestedFacebookFeatures=Share -p:ExpectedLoginEnabled=False -p:ExpectedShareEnabled=True

dotnet msbuild "$project" -t:ValidateFeatureSelection -p:RequestedFacebookFeatures=Login%3BShare -p:ExpectedLoginEnabled=True -p:ExpectedShareEnabled=True
Loading