fix key text defaults and preview height - #954
Open
AoSankaku wants to merge 2 commits into
Open
Conversation
Owner
|
PR の作成ありがとうございます。
こちらについては、問題ないように思いました。
こちらについては、既存ユーザーのキー文字サイズがアップデート後に変わってしまう可能性がある点が気になりました。 |
Contributor
Author
|
早速ご確認ありがとうございます。 こちらのデフォルトフォントサイズ機能変更案については、Gboard、Flick日本語入力のデフォルトキーフォントサイズを考慮してサイズを引き上げたものになります。具体的な比較データを後ほど提供いたしますのでしばらくお待ちください。こちらの内容だけ隔離してDiscussionなどに移すのもアリだと考えます。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #933