Fix leaking in ImmutableList#fromArray - #3968
Open
wadoon wants to merge 3 commits into
Open
Conversation
mattulbrich
approved these changes
Aug 16, 2026
| default ImmutableList<T> prepend(T... array) { | ||
| return new ImmutableListConcat<>(ImmutableList.fromArray(array), this); | ||
| // weigl: here we can use the leaky version | ||
| return new ImmutableListConcat<>(new ImmutableListArray<>(array), this); |
Member
There was a problem hiding this comment.
I do not think we use this here. See the added test cases ...
| /// @param array the array to wrap | ||
| /// @return an ImmutableList containing the elements of the input array | ||
| static <T extends @Nullable Object> ImmutableList<T> fromArray(T[] array) { | ||
| return new ImmutableListArray<>(Arrays.copyOf(array, array.length)); |
Member
There was a problem hiding this comment.
suggest to use array.clone().
Member
There was a problem hiding this comment.
(to make the checker framework happy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request closes #3967.
Intended Change
Type of pull request
Ensuring quality