Support implicit TLS on port 465#12
Open
bugacha wants to merge 1 commit into
Open
Conversation
When tls-mode is "tls" and the SMTP port is 465, use implicit TLS (SMTPS via mail.WithSSL()) instead of STARTTLS. go-mail already supports this; other ports keep using WithTLSPolicy(TLSMandatory) (STARTTLS on 587/25).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--tls-mode tlsis used with SMTP port 465, Mail2Go now dials with implicit TLS (SMTPS) viamail.WithSSL()instead of STARTTLS. Port 465 expects TLS from the first byte, so the previousWithTLSPolicy(mail.TLSMandatory)(which negotiates STARTTLS on a plaintext connection) fails against implicit-TLS-only servers.Other ports (e.g. 587, 25) are unchanged and keep using STARTTLS via
WithTLSPolicy(mail.TLSMandatory).The underlying
go-maillibrary already supports both modes; this only wires up the port-465 case.Change
Testing
CGO_ENABLED=0 go build -o mail2go .succeeds.--tls-mode tls --smtp-port 465.