-
Notifications
You must be signed in to change notification settings - Fork 82
Thycotic secret ids arg #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thycotic secret ids arg #2148
Changes from all commits
0ff9353
55e4503
f3559f3
b8540a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -341,6 +341,30 @@ | |
| secrets_ids.extend([x['id'] for x in auth.thycotic_search(query)]) | ||
| else: | ||
| secrets_ids = [x['id'] for x in auth.thycotic_search(f'/v1/secrets/lookup')] | ||
|
|
||
| # secret_ids arg | ||
| debug_ids = kwargs.get('secret_ids') | ||
| if debug_ids is not None: | ||
| # Convert CLI string input into list | ||
| if isinstance(debug_ids,str): | ||
| debug_ids = debug_ids.replace(' ','').split(',') | ||
| # Handle secret IDs list | ||
| if isinstance(debug_ids,list): | ||
| # Deduplicate | ||
| debug_ids = list(set(debug_ids)) | ||
| # Check whether secrets were found in the lookup | ||
| stringified_secrets_ids = [str(x) for x in secrets_ids] | ||
| stringified_debug_ids = [str(x) for x in debug_ids] | ||
| found_secrets = [x for x in stringified_debug_ids if x in stringified_secrets_ids] | ||
| logging.info(f'From the specified {len(debug_ids)} secret IDs, {len(found_secrets)} were found in the secret server lookup.') | ||
| logging.info(', '.join(found_secrets)) | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading |
||
|
|
||
| # Replace import list with specified IDs | ||
| secrets_ids = debug_ids | ||
| else: | ||
| # Quit if secret IDs != list | ||
| logging.warning('Invalid input for secret IDs, exiting.') | ||
| return | ||
|
|
||
| self._send_keep_alive_if_needed(params) | ||
| print(f'Loading {len(secrets_ids)} Records ', flush=True, end='') | ||
|
|
@@ -779,12 +803,12 @@ | |
| except requests.exceptions.ConnectionError: | ||
| time.sleep(10) | ||
| rs = requests.get(url, headers=headers, verify=False, proxies=self.proxy) | ||
| if rs.status_code != 200: | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading |
||
| error_rs = rs.json() | ||
| raise Exception(error_rs['message']) | ||
| chunk_rs = rs.json() | ||
| records = chunk_rs.get('records') | ||
| if isinstance(records, list): | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading |
||
| result.extend(records) | ||
| else: | ||
| break | ||
|
|
@@ -792,9 +816,9 @@ | |
| skip = chunk_rs['nextSkip'] | ||
| else: | ||
| break | ||
| return result | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading |
||
|
|
||
| def thycotic_entity(self, endpoint): # type: (str) -> Optional[dict] | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) as clear text. This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading |
||
| self.ensure_auth_token() | ||
| headers = { | ||
| 'Accept': 'application/json', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.