Skip to content

KC-1315, KC-1329: Fix share-folder record expiration and ROE handling #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amangalampalli-ks merged 9 commits into from
Jul 9, 2026
Merged

KC-1315, KC-1329: Fix share-folder record expiration and ROE handling #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5db6ce
Fix share-folder record expiration removing owner records and breakin…
sshrushanth-ks Jun 16, 2026
6548788
Share-folder: expire folder and record access together; log expiry in…
sshrushanth-ks Jun 24, 2026
8a868d5
updated test file
sshrushanth-ks Jun 24, 2026
8166b54
Fix share-folder remove vault deletion; clean up access grant/remove …
sshrushanth-ks Jun 28, 2026
d5b9b31
Fix share folder expire in and -r combination
amangalampalli-ks Jun 30, 2026
b445c56
Separate folder and record flag usage to fix multiple remove related …
amangalampalli-ks Jul 2, 2026
5f5e0a4
Fix -p and -o flags and 1mi expiry
amangalampalli-ks Jul 3, 2026
e2db675
Restrict outside records to be shared via -r
amangalampalli-ks Jul 3, 2026
0663292
Update help
amangalampalli-ks Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions keepercommander/commands/nested_share_folder/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,13 @@ def walk(fuid):
# Expiration parsing
# ═══════════════════════════════════════════════════════════════════════════

def validate_share_expiration_timestamp(expiration_ms, cmd_name):
def validate_share_expiration_timestamp(expiration_ms, cmd_name, *, now_ms=None):
"""Reject finite expirations that are less than one minute."""
if expiration_ms is None or expiration_ms == -1:
return
min_allowed = int(datetime.datetime.now(timezone.utc).timestamp() * 1000) + MIN_SHARE_EXPIRATION_MS
if expiration_ms < min_allowed:
if now_ms is None:
now_ms = int(datetime.datetime.now(timezone.utc).timestamp() * 1000)
if expiration_ms < now_ms + MIN_SHARE_EXPIRATION_MS:
raise CommandError(
cmd_name,
'Share expiration must be at least 1 minute.',
Expand Down
Loading
Loading