DR-1295 Add pamGitHubConfiguration record support#2194
Closed
mfordkeeper wants to merge 6 commits into
Closed
Conversation
…naccessible When using Commander over SSH, pyperclip cannot access the local browser's clipboard. Selecting 'p' now prompts for manual token input if the clipboard is unreadable or returns content too short to be a valid SSO token. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mfordkeeper
requested review from
jwalstra-keeper,
m-afanasiuk,
maksimu and
miroberts
Use DOMAIN\username for icacls /grant instead of bare os.getlogin(), which fails when the machine name and username are the same string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow new PAM config type for GitHub. Only used for universal secrets sync. Most of the configuration needed for this record type to perform a secrets sync is going in the DAG.
Works in conjunction with https://github.com/Keeper-Security/record-templates/pull/52/
For more details, see: https://docs.google.com/document/d/10K8Xr0VpqRIawXSrTV3KoQb77CUrjU3PyMvphIhgyHI/edit?usp=drive_link