Skip to content

KC-1315, KC-1329: Fix share-folder expiration, remove semantics, and record permissions #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sk-keeper merged 1 commit into from
Jul 9, 2026
Merged

KC-1315, KC-1329: Fix share-folder expiration, remove semantics, and record permissions #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions keepercommander/commands/nested_share_folder/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,13 @@ def walk(fuid):
# Expiration parsing
# ═══════════════════════════════════════════════════════════════════════════

def validate_share_expiration_timestamp(expiration_ms, cmd_name):
def validate_share_expiration_timestamp(expiration_ms, cmd_name, *, now_ms=None):
"""Reject finite expirations that are less than one minute."""
if expiration_ms is None or expiration_ms == -1:
return
min_allowed = int(datetime.datetime.now(timezone.utc).timestamp() * 1000) + MIN_SHARE_EXPIRATION_MS
if expiration_ms < min_allowed:
if now_ms is None:
now_ms = int(datetime.datetime.now(timezone.utc).timestamp() * 1000)
if expiration_ms < now_ms + MIN_SHARE_EXPIRATION_MS:
raise CommandError(
cmd_name,
'Share expiration must be at least 1 minute.',
Expand Down
Loading
Loading