NSF record (add, update and details) and folder (add and remove) operation.#184
Closed
ukumar-ks wants to merge 16 commits into
Closed
NSF record (add, update and details) and folder (add and remove) operation.#184ukumar-ks wants to merge 16 commits into
ukumar-ks wants to merge 16 commits into
Conversation
ukumar-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
ukumar-ks
force-pushed
the
feature-kd-commands-part2-int
branch
from
e8efc2b to
6db7cac
Compare
This comment has been minimized.
This comment has been minimized.
sali-ks
approved these changes
Jul 6, 2026
sgaddala-ks
reviewed
Jul 6, 2026
| return { recordUid, recordAdd } | ||
| } | ||
|
|
||
| export async function addNestedShareRecord( |
Contributor
There was a problem hiding this comment.
this is good but vault/records/v3/add supports batching size of 1000. Add support for that in this function or as a different function.
Comment on lines
+362
to
+365
| if (entry.owner) return 'owner' | ||
| if (entry.role) return entry.role | ||
| if (entry.shareAdmin) return 'shared-manager' | ||
| return 'content-manager' |
Contributor
There was a problem hiding this comment.
return should be enum, not surprise strings
| inheritPermissions | ||
| ) | ||
|
|
||
| const response = await auth.executeRest(folderAddMessage({ folderData: [folderData] })) |
sgaddala-ks
reviewed
Jul 7, 2026
| if (!folderKey) continue | ||
| try { | ||
| return await platform.aesGcmDecrypt(encryptedKey, folderKey) | ||
| } catch (gcmErr) { |
Contributor
There was a problem hiding this comment.
you cached for gcmErr but what about default case ? in case of default log and throw error.
| hasFileFields: boolean | ||
| } | ||
|
|
||
| /** @deprecated Use ParsedNsfFields */ |
Contributor
There was a problem hiding this comment.
do we really need deprecated here ?
sgaddala-ks
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.