Add agent skill - #19
Merged
Merged
Conversation
start.sh had an unbounded wait on uvicorn: if the backend died during
startup the loop spun forever, Next.js never started, nothing ever bound
$PORT, and the platform killed the dyno for failing to bind -- with
nothing in the log explaining why. That is exactly the shape of the
current outage, so make the failure loud instead of silent:
- bound the wait and verify uvicorn is still alive each iteration
- print FATAL with the reason and exit non-zero on failure
- bind Next.js to 0.0.0.0 explicitly so the platform's port check
reliably sees the listener on the external interface
- forward SIGTERM to both children and exit if either dies
Also drop .git (387 MB) and db_export.zip (192 MB) from the build
context. Neither is needed at runtime, and the web image is pulled on
every dyno start, so the weight directly slows boots (measured pulls of
30-80s). Cuts the image from 4.32 GB to 3.09 GB uncompressed.
Note prompt/ is deliberately NOT excluded -- query_expansion.py loads
prompt/augment_prompt.j2 at runtime.
There was a problem hiding this comment.
Pull request overview
This PR updates runtime/process management and the indexing/deploy workflow to be more robust (clean shutdowns, bounded readiness waits, safer CI gating/retries), and reduces Docker build context size for faster dyno boots.
Changes:
- Harden
start.shwith strict bash settings, signal forwarding, bounded backend readiness wait, and supervision of backend/frontend child processes. - Update the indexing workflow to run daily with concurrency control, add gating when
jixiacan’t build against the current PhysLib toolchain, add retries for transient failures, and add deploy health verification. - Expand
.dockerignoreto reduce Docker build context size.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| start.sh | Adds strict mode, clean shutdown handling, bounded uvicorn readiness wait, and child process supervision. |
| .github/workflows/weekly-index.yml | Makes indexing daily, prevents concurrent runs, gates on jixia compatibility, adds retries/size checks, and verifies deploy health. |
| .dockerignore | Excludes additional non-runtime files from the Docker build context to speed up image builds/boots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+36
| paper/ | ||
| *.png | ||
| *.jpg |
| @@ -1,10 +1,15 @@ | |||
| name: Weekly Index | |||
| name: Index | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.