Remove useless SDL3::Headers settings. - #1243
Merged
Merged
Conversation
The only result of adding such targets to target_include_directories is the
addition of the non-existent "${CMAKE_CURRENT_SOURCE_DIR}/SDL3::Headers"
directory. Such targets have to be added to target_link_libraries in which
case their INTERFACE_INCLUDE_DIRECTORIES properties is added to the target's
include directories. In this case the parent SDL3::SDL3 library is added
which also adds SDL3::Headers. Thus this change simply deletes the useless
settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only result of adding such targets to target_include_directories is the addition of the non-existent "${CMAKE_CURRENT_SOURCE_DIR}/SDL3::Headers" directory. Such targets have to be added to target_link_libraries in which case their INTERFACE_INCLUDE_DIRECTORIES property is added to the target's include directories. In this case the parent SDL3::SDL3 library had already been added which also adds SDL3::Headers. Thus this change simply deletes the useless settings.