Skip to content

Second Sync Update #86

Draft
DRx3D wants to merge 4 commits into
KhronosGroup:mainfrom
DRx3D:Sync-2
Draft

Second Sync Update #86
DRx3D wants to merge 4 commits into
KhronosGroup:mainfrom
DRx3D:Sync-2

Conversation

@DRx3D

@DRx3D DRx3D commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

The models added here need some assistance - mostly descriptions. This is meant to be applied after PR #85 and after the 'issues' tag has been removed.

The new models in this PR are:

  1. ClearcoatRing
  2. ClearcoatSphere
  3. SheenHighHeel
  4. SuzanneMorphSparse
  5. TransmissionSuzanne

In addition other models may have had various updates to READMEs to improve the formatting.

@DRx3D

DRx3D commented Dec 22, 2023

Copy link
Copy Markdown
Contributor Author

All of the models listed in this PR all need descriptions. Most were supplied by UX3D. Tagging a few UX3D people to attract their attention. The model description can be added as a comment and I will get it into the system. You can also create a PR against the forked branch if it is a substantial change.

@UX3D-becher , @UX3D-haertl , @UX3D-kanzler

Model READMEs (from the PR source)

  1. ClearcoatRing
  2. ClearcoatSphere
  3. SheenHighHeel
  4. TransmissionSuzanne

@DRx3D

DRx3D commented Dec 22, 2023

Copy link
Copy Markdown
Contributor Author

@javagl, @lexaknyazev : The SuzanneMorphSparse model needs a description. Can either of you provide something simple for this?

@DRx3D DRx3D mentioned this pull request Dec 22, 2023
@javagl

javagl commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Maybe this was already supposed to be reviewed, and I missed it, but I'd suggest to not include SuzanneMorphSparse in its current form.

  • It claims to use KHR_materials_unlit and KHR_texture_transform but uses neither of these
  • It contains some undocumented/useless extras
  • It contains a node that has rotation/translation/scale set, but all with their default values
  • Most importantly: It does not contain any morph animation.

I don't know where the screenshot GIF comes from, but none of the common viewers that I tried shows anything "animated" there. (That small white thing that appears (in the GIF) in the lower left when the eyes are closed are a minor detail at this point...)

I know that this means that #61 will remain open, but... that's what it is for now.

@lexaknyazev

Copy link
Copy Markdown
Member

It contains some undocumented/useless extras

Those are actually spec-suggested, see the note at the end of the Morph Targets spec section. Agreed with all other points.

There's also inconsistent indentation in SuzanneMorphSparse/metadata.json.

@DRx3D DRx3D marked this pull request as draft January 5, 2024 21:01
@DRx3D

DRx3D commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

Changed to Draft so comments can be resolved without merging.

@emackey

emackey commented Jan 23, 2026

Copy link
Copy Markdown
Member

@DRx3D Is this still needed? There are lots of conflicts and this looks obsolete now. Anything to salvage here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants