Skip to content

Cloud Agent Next - Add logging around ephemeral sandbox destroy and wrapper liveness watchdog#4344

Open
eshurakov wants to merge 1 commit into
mainfrom
lopsided-show
Open

Cloud Agent Next - Add logging around ephemeral sandbox destroy and wrapper liveness watchdog#4344
eshurakov wants to merge 1 commit into
mainfrom
lopsided-show

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

Summary

Adds structured logging around ephemeral sandbox lifecycle and wrapper liveness watchdog paths in cloud-agent-next. CloudAgentSession now logs when ephemeral sandbox destroy is scheduled, re-armed, skipped, due, succeeds, or fails; it also forces wrapper stop and schedules destroy on terminal wrapper events for ephemeral code-review sandboxes. wrapper-supervisor now warns when the liveness watchdog stops tracking while accepted messages remain non-terminal, and logs wrapper stop reconciliation.

Verification

N/A

Visual Changes

N/A

Reviewer Notes

N/A

@kilo-code-bot

kilo-code-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the structured-logging additions for ephemeral sandbox destroy and wrapper liveness watchdog paths; the changes are additive logging plus one behavior-preserving try/catch (error is still rethrown identically), with no security, correctness, or performance concerns found in the changed lines.

Files Reviewed (2 files)
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts
  • services/cloud-agent-next/src/session/wrapper-supervisor.ts

Reviewed by claude-sonnet-5 · Input: 6.3K · Output: 8.8K · Cached: 858K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants