Cloud Agent Next - Add logging around ephemeral sandbox destroy and wrapper liveness watchdog#4344
Open
eshurakov wants to merge 1 commit into
Open
Cloud Agent Next - Add logging around ephemeral sandbox destroy and wrapper liveness watchdog#4344eshurakov wants to merge 1 commit into
eshurakov wants to merge 1 commit into
Conversation
…and wrapper liveness watchdog
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the structured-logging additions for ephemeral sandbox destroy and wrapper liveness watchdog paths; the changes are additive logging plus one behavior-preserving try/catch (error is still rethrown identically), with no security, correctness, or performance concerns found in the changed lines. Files Reviewed (2 files)
Reviewed by claude-sonnet-5 · Input: 6.3K · Output: 8.8K · Cached: 858K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured logging around ephemeral sandbox lifecycle and wrapper liveness watchdog paths in
cloud-agent-next.CloudAgentSessionnow logs when ephemeral sandbox destroy is scheduled, re-armed, skipped, due, succeeds, or fails; it also forces wrapper stop and schedules destroy on terminal wrapper events for ephemeral code-review sandboxes.wrapper-supervisornow warns when the liveness watchdog stops tracking while accepted messages remain non-terminal, and logs wrapper stop reconciliation.Verification
N/A
Visual Changes
N/A
Reviewer Notes
N/A