refactor(cloud-agent-next): drop elapsed ms from process diagnostic#4359
Open
eshurakov wants to merge 1 commit into
Open
refactor(cloud-agent-next): drop elapsed ms from process diagnostic#4359eshurakov wants to merge 1 commit into
eshurakov wants to merge 1 commit into
Conversation
The 'elapsed Nms' clause in createSafeProcessDiagnostic offered no operational signal to recipients (it varied by host, command, and redaction) and inflated the user-facing termination detail that gets re-prefixed by safe-failure-projection for every workspace-setup and command-runner error path. Internal ExecResult.elapsedMs is preserved for telemetry. Updates affected unit tests in wrapper/src and test/unit/wrapper/. Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed a single-line removal of the Files Reviewed (5 files)
Reviewed by claude-sonnet-5-20260630 · Input: 20 · Output: 3.6K · Cached: 477.9K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the
elapsed Nmsclause from the user-facing process diagnostic emitted bycreateSafeProcessDiagnosticinservices/cloud-agent-next/wrapper/src/utils.ts. This clause carried no operational signal for recipients — duration varied by host, command, and redaction — and it inflated the termination detail that gets re-prefixed bysafe-failure-projectionfor every workspace-setup and command-runner error path. The result surfaces as shorter, more focused details in user-visible messages such as:Workspace setup failed: sandbox storage full: termination nonzero exit, exit code 128(down from... elapsed 182966ms)ExecResult.elapsedMsis preserved on the wrapper side for telemetry.Verification
pnpm --filter cloud-agent-next exec vitest run test/unit/wrapper/utils.test.ts wrapper/src/session-bootstrap.test.ts wrapper/src/server.test.ts src/kilo/wrapper-ready-error.test.ts— 20/20 pass.pnpm --filter cloud-agent-next run format— clean.pnpm --filter cloud-agent-next run lint— clean.pnpm --filter cloud-agent-next exec typecheckwas not run; the change is one source line and matching test-assertion text updates, with no signature/type surface changes.Visual Changes
N/A — affects an internal log/diagnostic string only; no UI change.
Reviewer Notes
server.test.ts,session-bootstrap.test.ts) andkilo/wrapper-ready-error.test.tsonly have expected-detail string updates.ExecResult.elapsedMsis intentionally retained: it is still set byrunProcessand consumed by other call sites for timing (e.g.kilo import finished outcome=... elapsedMs=...structured logs inrestore-session.ts).--force-with-leaseafter rebasing onto the latestmain("Skip Bedrock for Fable" moved in) and replacing a stalewipcommit that had also bundled an unrelated oxfmt pass on the auto-generateddefault-slash-commands.generated.ts.