Skip to content

Do some chores. - #252

Merged
Kim-J-Smith merged 2 commits into
version-2.5.2from
v2.5.2/chores
Oct 31, 2026
Merged

Kim-J-Smith merged 2 commits into
version-2.5.2from
v2.5.2/chores

Conversation

@Kim-J-Smith

Copy link
Copy Markdown
Owner
  1. Remove unnecessary protected: in member_variable_impl.
  2. Add more assertions in exception tests.

@Kim-J-Smith Kim-J-Smith added the chore Some tiny improvements or changes. No API or ABI breaking. label Oct 31, 2026
@Kim-J-Smith

Copy link
Copy Markdown
Owner Author
#6 [2/3] RUN wget -q "https://cmake.org/files/v3.15/cmake-3.15.7-Linux-x86_64.tar.gz"     -O /tmp/cmake.tar.gz     && tar -xzf /tmp/cmake.tar.gz -C /usr/local --strip-components=1     && rm -f /tmp/cmake.tar.gz
#6 ERROR: process "/bin/sh -c wget -q \"[https://cmake.org/files/v3.15/cmake-${CMAKE_VERSION}-Linux-x86_64.tar.gz\](https://cmake.org/files/v3.15/cmake-$%7BCMAKE_VERSION%7D-Linux-x86_64.tar.gz/)"     -O /tmp/cmake.tar.gz     && tar -xzf /tmp/cmake.tar.gz -C /usr/local --strip-components=1     && rm -f /tmp/cmake.tar.gz" did not complete successfully: exit code: 4
------
 > [2/3] RUN wget -q "https://cmake.org/files/v3.15/cmake-3.15.7-Linux-x86_64.tar.gz"     -O /tmp/cmake.tar.gz     && tar -xzf /tmp/cmake.tar.gz -C /usr/local --strip-components=1     && rm -f /tmp/cmake.tar.gz:
------
Dockerfile:6
--------------------
   5 |     
   6 | >>> RUN wget -q "[https://cmake.org/files/v3.15/cmake-${CMAKE_VERSION}-Linux-x86_64.tar.gz](https://cmake.org/files/v3.15/cmake-$%7BCMAKE_VERSION%7D-Linux-x86_64.tar.gz)" \
   7 | >>>     -O /tmp/cmake.tar.gz \
   8 | >>>     && tar -xzf /tmp/cmake.tar.gz -C /usr/local --strip-components=1 \
   9 | >>>     && rm -f /tmp/cmake.tar.gz
  10 |     
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c wget -q \"[https://cmake.org/files/v3.15/cmake-${CMAKE_VERSION}-Linux-x86_64.tar.gz\](https://cmake.org/files/v3.15/cmake-$%7BCMAKE_VERSION%7D-Linux-x86_64.tar.gz/)"     -O /tmp/cmake.tar.gz     && tar -xzf /tmp/cmake.tar.gz -C /usr/local --strip-components=1     && rm -f /tmp/cmake.tar.gz" did not complete successfully: exit code: 4
Error: Process completed with exit code 1.

@Kim-J-Smith

Copy link
Copy Markdown
Owner Author

Re-run GCC 5 CI.

@Kim-J-Smith
Kim-J-Smith merged commit 0b931a0 into version-2.5.2 Oct 31, 2026
20 of 21 checks passed
Kim-J-Smith added a commit that referenced this pull request Oct 31, 2026
1. Remove unnecessary `protected:` in `member_variable_impl`.
2. Add more assertions in exception tests.
@Kim-J-Smith
Kim-J-Smith deleted the v2.5.2/chores branch November 1, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Some tiny improvements or changes. No API or ABI breaking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant