Skip to content

Consume typed terminal engine errors - #13328

Draft
pierremtb wants to merge 3 commits into
mainfrom
pierremtb/issue-13161-typed-terminal-engine-errors
Draft

Consume typed terminal engine errors#13328
pierremtb wants to merge 3 commits into
mainfrom
pierremtb/issue-13161-typed-terminal-engine-errors

Conversation

@pierremtb

@pierremtb pierremtb commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • consume the typed modeling connection_error websocket response
  • map every currently emitted connection error code to the app-level error taxonomy and honor the API's retryable field
  • remove the base PR's legacy backend-message classifier and legacy auth-error handling
  • include the cloud project ID in typed backend-disconnect telemetry when it is available
  • preserve regression coverage proving the common pre-header auth_token_missing response is non-terminal

Stack

This PR intentionally targets pierremtb/issue-13161-terminal-engine-errors, not main, and assumes the API change deploys first. The latest published @kittycad/lib (4.4.9) still lacks ModelingWebSocketResponse, ConnectionErrorWebSocketResponse, and ModelingConnectionErrorCode, so the local compatibility type remains until the schema is released; it can then become a type-only import.

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 8, 2026 5:35pm UTC

Request Review

@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 5115fc6 to 4627b92 Compare August 26, 2026 10:56
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-terminal-engine-errors branch from fac6dcc to 4e5d7f1 Compare September 7, 2026 15:40
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 4627b92 to 187c6de Compare September 7, 2026 15:46
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 187c6de to 0b4304a Compare September 7, 2026 20:12
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-terminal-engine-errors branch from 742e136 to 7ab0897 Compare September 7, 2026 20:21
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 0b4304a to 556d88b Compare September 7, 2026 20:25
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-terminal-engine-errors branch from 7ab0897 to 125f5c5 Compare September 7, 2026 20:29
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 556d88b to b248fa5 Compare September 7, 2026 20:30
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-terminal-engine-errors branch from 125f5c5 to 9a8f1f4 Compare September 7, 2026 20:56
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from b248fa5 to 5035d09 Compare September 7, 2026 20:57
@pierremtb
pierremtb force-pushed the pierremtb/issue-13161-typed-terminal-engine-errors branch from 5035d09 to e0ecb80 Compare September 8, 2026 17:23
Base automatically changed from pierremtb/issue-13161-terminal-engine-errors to main September 10, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant