Curate available filters instead of auto-generation#3671
Open
williamjallen wants to merge 1 commit intoKitware:masterfrom
Open
Curate available filters instead of auto-generation#3671williamjallen wants to merge 1 commit intoKitware:masterfrom
williamjallen wants to merge 1 commit intoKitware:masterfrom
Conversation
Filters are currently automatically-generated based on the available GraphQL fields for a given filter input type. That works wonderfully when filtering by primary records, but breaks down when trying to add support for relationship filtering. For example, it would be difficult to add label relationship filters because users expect labels to simply be text strings, when in reality they are shared entities with id and text columns. This PR completely rewrites the filter UI field generation logic to instead use a predetermined list of available filter fields. The available fields are identical to the fields previously available. I plan to immediately follow this PR with a PR which adds label relationship filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters are currently automatically-generated based on the available GraphQL fields for a given filter input type. That works wonderfully when filtering by primary records, but breaks down when trying to add support for relationship filtering. For example, it would be difficult to add label relationship filters because users expect labels to simply be text strings, when in reality they are shared entities with id and text columns. This PR completely rewrites the filter UI field generation logic to instead use a predetermined list of available filter fields. The available fields are identical to the fields previously available. I plan to immediately follow this PR with a PR which adds label relationship filters.