You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This also adds authentication to the status query to match the rate-limit of the POST. I'm not sure if it's strictly necessary, but I found it useful when testing.
@hainest looks good, this might be out of the scope of this PR, it will be nice to add a unit test that checks the status of a a known commit in cdash project. Feel free to do it here or in a followup PR
@hainest looks good, this might be out of the scope of this PR, it will be nice to add a unit test that checks the status of a a known commit in cdash project. Feel free to do it here or in a followup PR
Is that possible to do? I thought the dashboard history is cleared periodically.
@hainest looks good, this might be out of the scope of this PR, it will be nice to add a unit test that checks the status of a a known commit in cdash project. Feel free to do it here or in a followup PR
Is that possible to do? I thought the dashboard history is cleared periodically.
we could inquire a recent commit of a project such a cmake.
@hainest looks good, this might be out of the scope of this PR, it will be nice to add a unit test that checks the status of a a known commit in cdash project. Feel free to do it here or in a followup PR
Is that possible to do? I thought the dashboard history is cleared periodically.
we could inquire a recent commit of a project such a cmake.
@vicentebolea It's failing because the status is associated with the HEAD of the PR (fb36010), but it's testing the HEAD of master which is 392e931. That test will only pass on pushes for single-commit PRs that aren't rebase-and-merge or squash-and-merge.
@vicentebolea It's failing because the status is associated with the HEAD of the PR (fb36010), but it's testing the HEAD of master which is 392e931. That test will only pass on pushes for single-commit PRs that aren't rebase-and-merge or squash-and-merge.
Good catch. lets only allow merge commit merges to avoid this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds authentication to the status query to match the rate-limit of the POST. I'm not sure if it's strictly necessary, but I found it useful when testing.