Skip to content

Stop passing --no-embedded-pipe to viame train #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryonLewis merged 1 commit into from
Sep 2, 2026
+1 −3
Merged

Stop passing --no-embedded-pipe to viame train #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/platform/desktop/backend/native/viame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,6 @@ async function train(
`--config "${configFilePath}"`,
'--no-query',
'--no-adv-prints',
'--no-embedded-pipe',
];

if (resumeDir) {
Expand Down
1 change: 0 additions & 1 deletion server/dive_tasks/run_training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ def train_pipeline(self: Task, params: TrainingJob):
"--config",
shlex.quote(str(config_file)),
"--no-query",
"--no-embedded-pipe",
]

if annotated_frames_only:
Expand Down
2 changes: 1 addition & 1 deletion server/tests/test_remote_ffprobe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def test_sanitize_subprocess_args_keeps_header_file_path():
def test_sanitize_subprocess_args_keeps_shell_command_string():
cmd = (
'. /opt/noaa/viame/setup_viame.sh && KWIVER_DEFAULT_LOG_LEVEL=warn '
'/opt/noaa/viame/bin/viame train --no-query --no-embedded-pipe'
'/opt/noaa/viame/bin/viame train --no-query'
)
assert utils.sanitize_subprocess_args_for_log(cmd) == cmd

Expand Down
Loading