Skip to content

Add version in module path#36

Merged
Jo-Byr merged 1 commit into
Kitware:masterfrom
Jo-Byr:add-version-in-module-path
Mar 24, 2026
Merged

Add version in module path#36
Jo-Byr merged 1 commit into
Kitware:masterfrom
Jo-Byr:add-version-in-module-path

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@jourdain I'm not sure this is the correct approach, especially since it requires to change the version number in 3 different places for each update.

@Jo-Byr Jo-Byr requested a review from jourdain January 30, 2026 13:59
Comment thread vue3-components/package.json Outdated
Comment thread src/trame_simput/module/__init__.py Outdated
Comment thread src/trame_simput/module/__init__.py Outdated
Comment thread vue2-components/package.json Outdated
Comment thread vue3-components/vite.config.js Outdated
@jourdain jourdain self-requested a review January 30, 2026 16:36

@jourdain jourdain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change is on the Python side to put the version on the directory not on the files.

@Jo-Byr Jo-Byr force-pushed the add-version-in-module-path branch from 7f0b124 to 2f30c8c Compare February 3, 2026 07:48
@jourdain jourdain self-requested a review February 3, 2026 15:08
@Jo-Byr Jo-Byr merged commit 0012c0c into Kitware:master Mar 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants