feat(vue3): bump to vuetify 4.0.5#34
Conversation
bourdaisj
force-pushed
the
bump-to-vuetify-4.0.5
branch
from
a3ac90f to
5cbbf13
Compare
|
mmh does not seem to work with enable_lab |
|
We need to keep serving vuetify3 and add vuetify4 and maybe mark it as a breaking change. They are heavy differences between 3 and 4. |
|
Makes sense my app style changes alot between the two versions |
|
Should we close that one or do you want to keep it via a force push and some other changes? |
|
@jourdain if someone else is going to tackle this in the next two weeks, this can be closed. otherwise I want to keep this open and finish the job |
|
No plan on our end so far. Go for it |
| @@ -91,8 +91,8 @@ jobs: | |||
| run: | | |||
| mkdir -p trame_vuetify/module/vue3-serve/{fonts,css} | |||
| cd trame_vuetify/module/vue3-serve | |||
There was a problem hiding this comment.
should be vuetify4-serve or something. Someone should still be able to choose between vuetify2, vuetify3, vuetify4 and at some point vuetify0...
| cd trame_vuetify/module/vue3-serve | ||
| curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.css -Lo vuetify3.css | ||
| curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.js -Lo vuetify3.js | ||
| curl https://cdn.jsdelivr.net/npm/vuetify@4.0.5/dist/vuetify.min.css -Lo vuetify3.css |
There was a problem hiding this comment.
you should copy it to vuetify4 not 3.
| @@ -232,32 +232,42 @@ def dataframe_to_grid(dataframe, options={}): | |||
| "image", | |||
| "increment", | |||
| "input", | |||
| "input.append-inner", | |||
There was a problem hiding this comment.
vuetify4 should not affect vuetify3
|
Are you going to refactor the following and add a new entry for v4? |
|
That probably mean a generator for widget for |
2 participants
first time doing this - did I miss something?