fix: Added test for env var PEM secret with indentation - #2218
Open
shivaygupta-dotcom wants to merge 3 commits into
Open
fix: Added test for env var PEM secret with indentation#2218shivaygupta-dotcom wants to merge 3 commits into
shivaygupta-dotcom wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2218 +/- ##
=======================================
Coverage 36.02% 36.02%
=======================================
Files 82 82
Lines 7844 7844
=======================================
Hits 2826 2826
Misses 4750 4750
Partials 268 268 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shivaygupta-dotcom
force-pushed
the
fix/env-var-pem-indentation
branch
from
August 31, 2026 15:39
626cc59 to
ad800a6
Compare
shivaygupta-dotcom
marked this pull request as ready for review
September 2, 2026 07:08
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
VarunAthreya
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test coverage for PEM certificates containing indentation to ensure they are correctly detected and masked without failures and prevents the certificate contents from being exposed in the output.
GDR PR: Kong/go-database-reconciler#516
GH: #2210