Skip to content

fix(release): read checks with workflow token - #180

Merged
tkkhq merged 4 commits into
mainfrom
fix/release-required-check-read
Sep 1, 2026
Merged

fix(release): read checks with workflow token#180
tkkhq merged 4 commits into
mainfrom
fix/release-required-check-read

Conversation

@tkkhq

@tkkhq tkkhq commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Tracking

Why

  • release automation cannot merge a ready release PR because the scoped app token receives HTTP 403 when it reads branch protection
  • feature-ref workflow dispatches can currently mint the privileged app token and run the release merge path
  • a review-bypass merge must remain blocked by every release CI signal

Summary

  • read required PR checks with the read-only workflow token
  • keep release PR discovery and merge on the scoped app token
  • require the complete nine-check server-enforced set before the app merge
  • wait for all reported checks and reject failed, cancelled, or pending results
  • restrict the release job to main and serialize all release runs in one concurrency group
  • run the release workflow guard in CI and reject unsafe token, ref, check, and merge behavior
  • configure main branch protection to require the nine current CI signals at merge time

Verification

Copilot AI balanced review requested due to automatic review settings September 1, 2026 04:06
@tkkhq
tkkhq requested a review from a team as a code owner September 1, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates release automation to read required PR checks with the workflow token while retaining the scoped app token for release operations.

Changes:

  • Grants read-only check and pull-request permissions.
  • Uses github.token for required-check discovery and waiting.
  • Adds workflow guards against branch-protection API usage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release-please.yml Separates check reads from app-authorized release writes.
scripts/ci/check-release-workflow.sh Validates token usage and required-check handling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@swkeever swkeever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workflow-token/app-token separation, main-ref guard, complete required-check gating, all-check fail-closed behavior, and head-SHA pinning. Local checks pass and the current required server checks match the enforced set.

@tkkhq
tkkhq merged commit 9c2b0a8 into main Sep 1, 2026
9 checks passed
@tkkhq
tkkhq deleted the fix/release-required-check-read branch September 1, 2026 13:04
@kong-volcano-app kong-volcano-app Bot mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants