Skip to content

[SI APP] Fixing sensor creation #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Igarizza wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[SI APP] Fixing sensor creation #14821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e437601
save util improve
Igarizza Sep 25, 2026
8ff9185
use Geo Bins instead of const elem id
Igarizza Sep 28, 2026
b7f2f64
fix miss tolerances between check and search
Igarizza Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions applications/SystemIdentificationApplication/custom_python/add_custom_sensors_to_python.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ void AddCustomSensorsToPython(pybind11::module& m)
py::arg("weight"),
py::arg("error_threshold") = Sensor::DefaultErrorThreshold)
.def_static("GetDefaultParameters", &DisplacementSensor::GetDefaultParameters)
.def_static("Create", &DisplacementSensor::Create, py::arg("domain_model_part"), py::arg("sensor_model_part"), py::arg("sensor_id"), py::arg("sensor_parameters"))
.def_static("Create", &DisplacementSensor::Create, py::arg("domain_model_part"), py::arg("sensor_model_part"), py::arg("sensor_id"), py::arg("sensor_parameters"), py::arg("domain_bins"))
;

auto strain_sensor = py::class_<StrainSensor, StrainSensor::Pointer, Sensor>(sensor_module, "StrainSensor");
Expand All @@ -93,7 +93,7 @@ void AddCustomSensorsToPython(pybind11::module& m)
py::arg("weight"),
py::arg("error_threshold") = Sensor::DefaultErrorThreshold)
.def_static("GetDefaultParameters", &StrainSensor::GetDefaultParameters)
.def_static("Create", &StrainSensor::Create, py::arg("domain_model_part"), py::arg("sensor_model_part"), py::arg("sensor_id"), py::arg("sensor_parameters"))
.def_static("Create", &StrainSensor::Create, py::arg("domain_model_part"), py::arg("sensor_model_part"), py::arg("sensor_id"), py::arg("sensor_parameters"), py::arg("domain_bins"))
;
}

Expand Down
19 changes: 11 additions & 8 deletions applications/SystemIdentificationApplication/custom_sensors/displacement_sensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
// External includes

// Project includes
#include "utilities/brute_force_point_locator.h"

// Application includes
#include "custom_utilities/sensor_utils.h"
Expand Down Expand Up @@ -48,8 +47,10 @@ DisplacementSensor::DisplacementSensor(
const auto& r_geometry = rElement.GetGeometry();
const auto& current_sensor_location = *(this->GetNode());

// same local coordinate tolerance as the domain bins used to find rElement, otherwise a
// point lying on a face shared by two elements may be rejected by the element the bins found.
Point local_point;
if (r_geometry.IsInside(current_sensor_location, local_point)) {
if (r_geometry.IsInside(current_sensor_location, local_point, 1e-6)) {
// point is within the geometry. Use shape function evaluations
// from the element geometry to get the shape function values.
r_geometry.ShapeFunctionsValues(mNs, local_point);
Expand Down Expand Up @@ -104,7 +105,8 @@ Sensor::Pointer DisplacementSensor::Create(
ModelPart& rDomainModelPart,
ModelPart& rSensorModelPart,
const IndexType Id,
Parameters SensorParameters)
Parameters SensorParameters,
GeometricalObjectsBins& rDomainBins)
{
KRATOS_TRY

Expand All @@ -120,12 +122,13 @@ Sensor::Pointer DisplacementSensor::Create(
<< "Location of the sensor \"" << SensorParameters["name"].GetString()
<< "\" should have 3 components. [ location = " << location << " ].\n";

Point loc(location[0], location[1], location[2]);

Vector dummy_shape_functions;
const auto search_result = rDomainBins.SearchIsInside(Point(location[0], location[1], location[2]));
KRATOS_ERROR_IF_NOT(search_result.GetIsObjectFound())
<< "Location of the sensor \"" << SensorParameters["name"].GetString()
<< "\" is not inside any element of " << rDomainModelPart.FullName()
<< ". [ location = " << location << " ].\n";

const auto element_id = BruteForcePointLocator(rDomainModelPart).FindElement(loc, dummy_shape_functions);
const auto& r_element = rDomainModelPart.GetElement(element_id);
const auto& r_element = rDomainModelPart.GetElement(search_result.Get()->Id());

auto p_node = rSensorModelPart.CreateNewNode(Id, location[0], location[1], location[2]);

Expand Down
9 changes: 8 additions & 1 deletion applications/SystemIdentificationApplication/custom_sensors/displacement_sensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
// Project includes
#include "includes/ublas_interface.h"
#include "includes/element.h"
#include "spatial_containers/geometrical_objects_bins.h"

// Application includes
#include "sensor.h"
Expand Down Expand Up @@ -64,11 +65,17 @@ class KRATOS_API(SYSTEM_IDENTIFICATION_APPLICATION) DisplacementSensor : public
///@name Static operations
///@{

/**
* @brief Creates the sensor at the location given in SensorParameters.
* @details rDomainBins must be built from the elements of rDomainModelPart. It is
* shared by all sensors, so each sensor is located without a linear search.
*/
static Sensor::Pointer Create(
ModelPart& rDomainModelPart,
ModelPart& rSensorModelPart,
const IndexType Id,
Parameters SensorParameters);
Parameters SensorParameters,
GeometricalObjectsBins& rDomainBins);

static Parameters GetDefaultParameters();

Expand Down
18 changes: 10 additions & 8 deletions applications/SystemIdentificationApplication/custom_sensors/strain_sensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

// Project includes
#include "includes/kratos_components.h"
#include "utilities/brute_force_point_locator.h"

// Application includes
#include "custom_utilities/sensor_utils.h"
Expand All @@ -41,7 +40,8 @@ StrainSensor::StrainSensor(
mStrainType(rStrainType),
mrStrainVariable(rStrainVariable)
{
KRATOS_ERROR_IF_NOT(rElement.GetGeometry().IsInside(*(this->GetNode()), mLocalPoint))
// same local coordinate tolerance as the domain bins used to find rElement
KRATOS_ERROR_IF_NOT(rElement.GetGeometry().IsInside(*(this->GetNode()), mLocalPoint, 1e-6))
<< "The point " << this->GetNode()->Coordinates() << " is not inside or on the boundary of the geometry of element with id "
<< mElementId << ".";

Expand Down Expand Up @@ -75,7 +75,8 @@ Sensor::Pointer StrainSensor::Create(
ModelPart& rDomainModelPart,
ModelPart& rSensorModelPart,
const IndexType Id,
Parameters SensorParameters)
Parameters SensorParameters,
GeometricalObjectsBins& rDomainBins)
{
KRATOS_TRY

Expand All @@ -86,12 +87,13 @@ Sensor::Pointer StrainSensor::Create(
<< "Location of the sensor \"" << SensorParameters["name"].GetString()
<< "\" should have 3 components. [ location = " << location << " ].\n";

Point loc(location[0], location[1], location[2]);

Vector dummy_shape_functions;
const auto search_result = rDomainBins.SearchIsInside(Point(location[0], location[1], location[2]));
KRATOS_ERROR_IF_NOT(search_result.GetIsObjectFound())
<< "Location of the sensor \"" << SensorParameters["name"].GetString()
<< "\" is not inside any element of " << rDomainModelPart.FullName()
<< ". [ location = " << location << " ].\n";

const auto element_id = BruteForcePointLocator(rDomainModelPart).FindElement(loc, dummy_shape_functions);
const auto& r_element = rDomainModelPart.GetElement(element_id);
const auto& r_element = rDomainModelPart.GetElement(search_result.Get()->Id());

auto p_node = rSensorModelPart.CreateNewNode(Id, location[0], location[1], location[2]);

Expand Down
9 changes: 8 additions & 1 deletion applications/SystemIdentificationApplication/custom_sensors/strain_sensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

// Project includes
#include "includes/element.h"
#include "spatial_containers/geometrical_objects_bins.h"

// Application includes
#include "sensor.h"
Expand Down Expand Up @@ -78,11 +79,17 @@ class KRATOS_API(SYSTEM_IDENTIFICATION_APPLICATION) StrainSensor : public Sensor
///@name Static operations
///@{

/**
* @brief Creates the sensor at the location given in SensorParameters.
* @details rDomainBins must be built from the elements of rDomainModelPart. It is
* shared by all sensors, so each sensor is located without a linear search.
*/
static Sensor::Pointer Create(
ModelPart& rDomainModelPart,
ModelPart& rSensorModelPart,
const IndexType Id,
Parameters SensorParameters);
Parameters SensorParameters,
GeometricalObjectsBins& rDomainBins);

static Parameters GetDefaultParameters();

Expand Down
8 changes: 4 additions & 4 deletions applications/SystemIdentificationApplication/python_scripts/sensor_generator_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def __GenerationBoundingSurfaceBased(self, sensors_dict, sensor_group_params: Kr
}""")
sensor_group_params.ValidateAndAssignDefaults(defaults)

point_locator = Kratos.BruteForcePointLocator(self.model_part)
# spatial search built once for all generated points (mesh is in its initial configuration here)
bins = Kratos.GeometricalObjectsBins(self.model_part.Elements, 1e-8)

corner_1 = sensor_group_params["bounding_surface_corner_1"].GetVector()
corner_2 = sensor_group_params["bounding_surface_corner_2"].GetVector()
Expand All @@ -83,9 +84,8 @@ def __GenerationBoundingSurfaceBased(self, sensors_dict, sensor_group_params: Kr
for i_z in range(number_of_sensors[2]):
z_coord = corner_1[2] + distance[2] * (i_z + 1) / (number_of_sensors[2] + 1)
loc = Kratos.Point(x_coord, y_coord, z_coord)
shape_funcs = Kratos.Vector()
elem_id = point_locator.FindElement(loc, shape_funcs, Kratos.Configuration.Initial, 1e-8)
if elem_id != -1 and KratosSI.SensorUtils.IsPointInGeometry(loc, self.model_part.GetElement(elem_id).GetGeometry()):
result = bins.SearchIsInside(loc)
if result.IsObjectFound() and KratosSI.SensorUtils.IsPointInGeometry(loc, self.model_part.GetElement(result.Get().Id).GetGeometry()):
current_params = sensor_params.Clone()
current_params["location"].SetVector(loc)
json_dict = json.loads(current_params.WriteJsonString().replace("<ENTITY_ID>", str(index)))
Expand Down
12 changes: 11 additions & 1 deletion applications/SystemIdentificationApplication/python_scripts/utilities/sensor_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ def CreateSensors(sensor_model_part: Kratos.ModelPart, domain_model_part: Kratos
except:
pass

# One spatial search over the domain elements, shared by all sensors, so each sensor's Create
# locates its element(s) without a linear search. Built lazily since empty bins are not searchable.
domain_bins: 'typing.Optional[Kratos.GeometricalObjectsBins]' = None

list_of_sensors: 'list[KratosSI.Sensors.Sensor]' = []
for parameters in list_of_parameters:
if not parameters.Has("type"):
Expand All @@ -47,7 +51,13 @@ def CreateSensors(sensor_model_part: Kratos.ModelPart, domain_model_part: Kratos
if not sensor_type_name in dict_of_sensor_types.keys():
raise RuntimeError(f"Unsupported sensor type = \"{sensor_type_name}\" requested. Followings are supported:\n\t" + "\n\t".join(dict_of_sensor_types.keys()))

sensor: KratosSI.Sensors.Sensor = dict_of_sensor_types[sensor_type_name].Create(domain_model_part, sensor_model_part, len(list_of_sensors) + 1, parameters)
if domain_bins is None:
if domain_model_part.NumberOfElements() == 0:
raise RuntimeError(f"The domain model part \"{domain_model_part.FullName()}\" has no elements to locate the sensors in.")
# same local coordinate tolerance as the former brute force point locator
domain_bins = Kratos.GeometricalObjectsBins(domain_model_part.Elements, 1e-6)

sensor: KratosSI.Sensors.Sensor = dict_of_sensor_types[sensor_type_name].Create(domain_model_part, sensor_model_part, len(list_of_sensors) + 1, parameters, domain_bins)
list_of_sensors.append(sensor)

return list_of_sensors
Expand Down
Loading