Skip to content

[RomApp] coupled fluid-thermal & thermo-mechanical complete rom hrom workflow with rom manager - #14826

Merged
Rbravo555 merged 7 commits into
masterfrom
rom/linear_coupled_solvers_rom_hrom
Oct 3, 2026
Merged

Rbravo555 merged 7 commits into
masterfrom
rom/linear_coupled_solvers_rom_hrom

Conversation

@Rbravo555

@Rbravo555 Rbravo555 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

📝 Description

Support for coupled fluid-thermal ROMs was added in PR #14573. This PR adds the full construction workflow for coupled simulations to RomManager, and extends coupled support to thermo-mechanical problems.

Coupled problems are declared through a top-level coupled_solvers list, with one entry per sub-solver. Each entry can override some of the general ROM/HROM settings:

"coupled_solvers": [
    {"sub_solver_name": "fluid_solver"},
    {"sub_solver_name": "thermal_solver",
     "ROM":  {"model_part_name": "ThermalModelPart", "nodal_unknowns": ["TEMPERATURE"]},
     "HROM": {"element_selection_svd_truncation_tolerance": 1e-5}}
]

If the list is omitted, the solvers are detected from the ProjectParameters.json. A single (monolithic) basis is built from the union of the solvers' nodal_unknowns. For the HROM, one set of elements and conditions is selected, with one set of weights per physics.

Coupled ROMs currently support linear decoders only.


🆕 Changelog

  • Feature: coupled_solvers list in the RomManager parameters, with validated per-solver ROM/HROM overrides.
  • Feature: One ECM per solver in RomManager, giving a single element set with one set of weights per physics (builds on PR [RomApp] Change HROM_WEIGHT variable to Vector type #14756).
  • Feature: ROM and HROM support for thermo-mechanical coupled problems.
  • Fix: rom_analysis injects the ROM settings into each sub-solve
  • Tests: Coupled RomManager training test, coupled_solvers validation tests, and thermo-mechanical ROM/HROM tests.

@Rbravo555 Rbravo555 added the ROM label Sep 30, 2026
@Rbravo555
Rbravo555 marked this pull request as ready for review September 30, 2026 11:57
@Rbravo555
Rbravo555 requested a review from a team as a code owner September 30, 2026 11:57
@Rbravo555 Rbravo555 changed the title [RomApp] coupled fluid thermal complete rom hrom workflow with rom manager [RomApp] coupled fluid-thermal & thermo-mechanical complete rom hrom workflow with rom manager Oct 2, 2026

@Marco1410 Marco1410 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Approved, so we can move forward.
Thanks Raul.

@Rbravo555
Rbravo555 merged commit 02e1f63 into master Oct 3, 2026
10 checks passed
@Rbravo555
Rbravo555 deleted the rom/linear_coupled_solvers_rom_hrom branch October 3, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants