Repository navigation
Conversation
…sion Synthetic "battle fought" events were assigned Id = Events.Count, which collides with real event ids whenever unsupported event types are skipped during parsing (common in late worldgen). The collision corrupts World.Events ordering so GetEvent's binary search resolves a battle's events to an unrelated, older battle. Assign synthetic ids above the highest existing id so World.Events stays sorted and collision-free. Adds regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
…llision #47 Fix late battles referencing unrelated battles (event id collision)
(map) support multiple sites on a single tile
…t target ring and crosshairs
… outer radar ring (#67)
…ive Leaflet map (#59)
…ter-events disabled (#59)
…el thread pool starvation (#34)
- Implement MatchesFilterCriteria in Entity.cs (IsCiv, HasCurrentSites, WorshipsDeity, EntityType, CurrentSitesCount, WarCount) - Create EntityFilter.vue component with 3-state bools, entity type selector, and numeric filters - Enable filter popup on Entities view
- Implement MatchesFilterCriteria in Site.cs (IsOccupied, HasStructures, SiteType, StructureCount, BattleCount) - Create SiteFilter.vue component with 3-state bools, site type selector, and numeric filters - Enable filter popup on Sites view
- Implement MatchesFilterCriteria in Region.cs (Biome/RegionType, Evilness, HasSites, HasForce, SquareTiles, SiteCount, BattleCount) - Create RegionFilter.vue component with biomes and alignment dropdowns, 3-state bools, and numeric filters - Refactor filter watchers across all filter components to use guarded props watcher to prevent dropdown selection reset - Enable filter popup on Regions view
…property merging bug
…erty parsing - Add PreserveBody to Circumstance enum and parse preservebody XML tag in ArtifactCreated - Format ArtifactCreated event text conditionally for PreserveBody and FavoritePossession - Handle entity in ArtifactCreated and interaction_source in HFLearnsSecret to avoid false-positive unknown property warnings when value is -1 - Add unit tests verifying ArtifactCreated formatting for preservebody and favoritepossession
- Implement WorldRecordsCalculator engine covering 6 categories (Warfare, Sovereigns, Lore, Intrigue, Longevity, Geography) - Add GET /api/World/records API endpoint with in-memory caching and world clear reset - Build interactive WorldRecords.vue view, Pinia store, and RecordCard.vue leaderboard components with text truncation - Update unit tests in LegendsParserTests.cs
…gorization, and details layout - Add connected sites (Start/End), master route, surface regions, underground regions, crossed rivers, and section links to WorldConstruction model. - Refine region resolution based on effective construction type (Roads show surface regions, Tunnels show underground regions, Bridges inherit master route type). - Enhance Construction.vue layout with direct region/river links in summary card for Bridges and detailed card lists for routes. - Add squareTiles (length) column to Constructions overview table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.