Skip to content

Fix ublox_msgs Windows portability #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Fischer wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Fix ublox_msgs Windows portability #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ublox_msgs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic)
endif()

if(WIN32)
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
endif()

find_package(ament_cmake_ros REQUIRED)
find_package(rosidl_default_generators REQUIRED)
find_package(sensor_msgs REQUIRED)
Expand Down
9 changes: 9 additions & 0 deletions ublox_msgs/include/ublox_msgs/ublox_msgs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,16 @@ namespace Message {
} // namespace RXM

namespace INF {
#if defined(_WIN32) && defined(ERROR)
#pragma push_macro("ERROR")
#undef ERROR
#define UBLOX_MSGS_RESTORE_ERROR_MACRO
#endif
static const uint8_t ERROR = 0x00;
#if defined(UBLOX_MSGS_RESTORE_ERROR_MACRO)
#pragma pop_macro("ERROR")
#undef UBLOX_MSGS_RESTORE_ERROR_MACRO
#endif
static const uint8_t WARNING = 0x01;
static const uint8_t NOTICE = 0x02;
static const uint8_t TEST = 0x03;
Expand Down