feat: add Bombora MEV bundle sender - #218
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
thanhpp
requested review from
datluongductuan and
vaigay
and removed request for
vaigay
August 21, 2026 09:21
thanhpp
commented
Aug 21, 2026
thanhpp
commented
Aug 21, 2026
thanhpp
commented
Aug 21, 2026
thanhpp
commented
Aug 21, 2026
thanhpp
commented
Aug 21, 2026
thanhpp
commented
Aug 21, 2026
- Drop bombora_sender_test.go; the manual t.Skip() pattern for other builders covers this, not an httptest harness. - Fix SendBundleParams.ReplacementUUID's JSON tag (ReplacementUuid -> replacementUuid) instead of adding a separate Bombora-only field. - Rename DroppingTxs -> DroppingTxHashes and make RefundRecipient a *string on SendBundleParams for consistency with the other optional Bombora fields. - Move the pre-existing StateBlockNumber field above the new Bombora field group so the diff no longer implies it is Bombora-specific. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: thanhpp <thanhphanphu18@gmail.com>
Signed-off-by: thanhpp <thanhphanphu18@gmail.com>
datluongductuan
approved these changes
Aug 21, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BundleSenderTypeBomboraas a new builder: enum value, endpoint constant, builder ID constant, and regenerated enumer file.SendBundleParams.SetBomboraFields, which copies Bombora-only bundle fields: dropping transaction hashes, replacement sequence number, refund percent, refund recipient, refund transaction hashes.SendBundleParams.ReplacementUUID's JSON tag fromReplacementUuidtoreplacementUuid, matching the real wire key used byCancelBundleParamsand Bombora's spec. This changes the wire key for every sender that goes throughSetUUIDand is not Beaver, Loki, or Jetbldr.ErrInvalidRefundPercent(must be 0-99,BomboraMaxRefundPercent) andErrInvalidLenRefundTxHashes(at most one hash).SendBundleV2callsSetBomboraFieldsonly when the client's sender type is Bombora, so other builders never see these fields on the wire.Test plan
go build ./...go test -race ./...golangci-lint run --config=.golangci.yml ./pkg/mev/...(only pre-existing issues remain, none on changed lines)🤖 Generated with Claude Code