Repository navigation
docs: the cancellation policy once a cancel crosses the wire - #870
Merged
Merged
Conversation
The policy table still said no cancel crosses the wire. Now a Task handler on a server that advertised `cancel` is asked to stop by SocketBackend/QtWebSocketBackend cancelPending and by the execute deadline (measured over a real loopback, net and Qt); the caller-token and co_await rows say the stop is relayed as a cancel over those backends (read, not measured for those verbs). The "No cancel crosses the wire" bullet goes, and backend.md's interim copy of the rows becomes a pointer to where they are measured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #866 and #867. #866 held
concurrency_and_lifetimes.mdwhile #867 was in flight, so #867 parked its policy-row changes inbackend.mdand listed them in its PR body. Both have now merged, so this PR moves the rows into the policy table.SocketBackend::cancelPendingandQtWebSocketBackend::cancelPending: the work column now says a Task handler on a server that advertisedcancelis asked to stop. That is measured over a real loopback through~Bridge. The G-levels stay read, as core, wire, net, qt: a hello-negotiated cancel envelope, honoured by RemoteServer and sent by both client backends (#864, #865) #867 reported.Bridge::setExecuteDeadline: the deadline's stop reaches the server's Task handler through acancelover either backend. Measured in the net and Qt suites, per core, wire, net, qt: a hello-negotiated cancel envelope, honoured by RemoteServer and sent by both client backends (#864, #865) #867.co_awaitrows: these said nocancelcrosses the wire. OverSocketBackendorQtWebSocketBackend, the call's stop source now triggers acancel. Those two verbs were not measured end to end over a real transport, so the rows say read, not measured for this verb. core: client-side stop plumbing: a stopped co_await stops its call; execute(action, StopToken) #866's own measurement usedSimulatedRemoteBackend, which sends nocancel, and that is kept.backend.md: the interim copy of the rows is replaced by a pointer to where they are measured. Nothing else linked to that section.Docs only. No code or tests change.
🤖 Generated with Claude Code