Fix usage of fract_base_dir and val_split#63
Merged
michaelmckinsey1 merged 14 commits intoLBANN:mainfrom May 6, 2026
Merged
Conversation
Collaborator
|
Why do we want to be able to change the |
Collaborator
Author
I changed it to 30 because the default number of samples in the validation dataset with our current config is 60 at 25% split. At a 30% split it is 72. The target is 64, since that allows for a global batch size up to 64 instead of 32 (powers of 2 because of sharding). We could also make it 27% to satisfy this constraint, but I just rounded up. |
Collaborator
|
In |
Collaborator
Author
I think this was a mistake, so I removed it. val_split is intentional so it generates a different dataset based on val split |
PatrickRMiles
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.