fix(dashboard): make change-ownership modal wallet input full-width (NODE-4976)#417
Merged
GTC6244 merged 1 commit intoMay 29, 2026
Merged
Conversation
…NODE-4976) The change-ownership modal used .form-input/.form-label classes that aren't defined anywhere in styles.css, so the address field fell back to default browser sizing — too narrow to display a full 0x… address. Switch to the dashboard's standard .form-group + .input pattern (already used by every other modal) and render the address in monospace for readability. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “Change account ownership” modal markup in the dashboard to use the existing dashboard form styling so the wallet-address input renders full-width and is easier to read.
Changes:
- Replace undefined
.form-input/.form-labelusage with the dashboard’s.form-group+.inputstructure. - Add monospace font styling to the wallet-address input to better display
0x…addresses.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
998
to
999
| `<button type="button" class="btn btn-secondary" id="change-ownership-cancel-btn">Cancel</button> | ||
| <button type="button" class="btn btn-primary" id="change-ownership-accept-btn">Accept</button>`, |
Contributor
Author
There was a problem hiding this comment.
Good catch — fixed in 10cff3b. Switched to .btn-outline to match every other dashboard modal's Cancel button.
GTC6244
added a commit
that referenced
this pull request
May 29, 2026
…utton (NODE-4976) `.btn-secondary` isn't defined in styles.css (only .btn-primary, .btn-outline, .btn-danger exist), so the Cancel button got no secondary styling. Every other dashboard modal's cancel button uses .btn-outline — match that. Caught by Copilot review on #417. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
GTC6244
added a commit
that referenced
this pull request
May 29, 2026
…utton (NODE-4976) (#418) `.btn-secondary` isn't defined in styles.css (only .btn-primary, .btn-outline, .btn-danger exist), so the change-ownership modal's Cancel button got no secondary styling. Every other dashboard modal's cancel button uses .btn-outline — match that. Follow-up to #417 (caught by Copilot review after merge). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Change account ownership" modal at
lit-static/dapps/dashboard/auth.jsused.form-input/.form-labelclass names that aren't defined anywhere instyles.css, so the wallet-address field fell back to default browser sizing — too narrow to show a full 42-char0x…address. Switched to the dashboard's standard.form-group+.inputpattern (already used by every other modal) and added a monospace font for the address, matching theusage-key-override-inputstyle.No JS logic changed; the input id, error element, button ids, and Enter/Escape handlers are intact so
tryAccept()and ethers validation still work.Test plan
0x…address is fully visible in monospaceLinear: https://linear.app/litprotocol/issue/NODE-4976
🤖 Generated with Claude Code