fix: link SPA contract-card titles to the detail pages (#611 follow-up)#613
Merged
rdmueller merged 1 commit intoJun 12, 2026
Merged
Conversation
…g#611) The static (no-JS) contracts fragment linked card titles to /contract/<id>, but the SPA replaces those cards on hydration with contracts-page.js markup whose titles were plain text — so with JavaScript enabled there was no visible way to reach or copy a contract link. Card titles are now links (the card's click-to-select handler already ignores clicks on <a> elements); localized tooltip added in EN and DE. Verified in the hydrated preview via Playwright: all 19 card titles link to their detail pages, and a direct /contract/specification URL titles the tab and scrolls to the card. Refs LLM-Coding#611 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughDie Änderungen machen ChangesVertrag Permalink-Implementierung und Lokalisierung
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #612, found through the obvious question "where do I see the change?": the no-JS contracts fragment linked card titles to the new
/contract/<id>pages, but the SPA replaces those cards on hydration withcontracts-page.jsmarkup whose titles were plain text — with JavaScript enabled there was no visible way to reach or copy a contract link.Change
/contract/<id>(the card's click-to-select handler already ignores<a>clicks, so selecting via card click is unaffected)contracts.permalink) in EN + DErenderContractCardexported for testing; new unit test asserts the title link (TDD, 108/108 pass)Verification
Playwright against the built preview:
/contracts/hydrated: 19/19 card titles link to their detail page/contract/specification/: tab title "Specification — Semantic Anchors", card scrolled into viewportRefs #611
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Documentation