Noah jaffe/randomized input delay - #149
Noah-Jaffe wants to merge 16 commits into
Conversation
…ATIONS FROM ENGLISH)
|
can someone review this please? the changes to the translations was AI supported and hand checked for consistency, but everything else is human |
Noah-Jaffe
left a comment
Noah-Jaffe
left a comment
There was a problem hiding this comment.
Some extra guidance for the reviewer, + change requests for me to do.
| self.icon.run() | ||
|
|
||
| def validate_input(self, action, value_if_allowed): | ||
| def validate_input_float(self, action, value_if_allowed): |
There was a problem hiding this comment.
Distribution settings allow for negative values, so float("-") would end up erroring and returning false. This may require the edge case be added for allowing just "-"? If just "-" is supplied, convert to zero.
| Button(button_area, text=main_app.text_content["global"]["confirm_button"], command=lambda: self.setNewValues(self.lowerInput.get(), self.upperInput.get(), main_app)).pack(side=LEFT, padx=10) | ||
| Button(button_area, text=main_app.text_content["global"]["cancel_button"], command=self.destroy).pack(side=LEFT, padx=10) | ||
| button_area.pack(side=BOTTOM, pady=10) | ||
| self.update_idletasks() |
| self.canvas.bind("<ButtonRelease-1>", self.finish_drawing) | ||
| # Draw the existing distribution, if one exists. | ||
| self.load_distribution(distribution) | ||
| self.update_idletasks() |
| settingFile_json = load(settingFile) | ||
| return settingFile_json | ||
|
|
||
| def update_settings(self): |
There was a problem hiding this comment.
Code quality checks flag this function as too complex, we can probably change this to do a nested merge with existing settings and the default settings file.
… proper continuous randomized value selection
Noah-Jaffe
left a comment
Noah-Jaffe
left a comment
There was a problem hiding this comment.
made changes from self review
|
|
Hmm I think i might be missing language support for some of the distribution window. I should probably fix that |
1 participant
Current status:
new bugs found, not ready for review.
In this PR: