Repository navigation
DM-56184: Various fixes from Rubin - #187
Merged
Merged
Conversation
Loading parameters.py will no longer try to set the backend. Instead, it will turn off the display mode if the env var is not set or if the matplotlib backend is set to a static (non-interactive) backend.
timj
commented
Sep 21, 2026
| plt.show() | ||
| if parameters.LSST_SAVEFIGPATH: | ||
| fig.savefig(os.path.join(parameters.LSST_SAVEFIGPATH, 'deconvolution_truth.pdf'), transparent=True) | ||
| plt.show() |
Contributor
Author
There was a problem hiding this comment.
@erykoff I assume this was deleted because there is a show only 3 lines above.
Contributor
There was a problem hiding this comment.
if it's DISPLAY it should show. This was showing the figure even if DISPLAY was false.
Coverage Report for CI Build 35665721009Coverage increased (+0.2%) to 89.012%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
jeremyneveu
approved these changes
Sep 22, 2026
Contributor
Author
|
@jeremyneveu Great. When you merge can you please then give us a formal release? It doesn't have to be on pypi. A GitHub release like you've done before is fine. Then we can make a conda-forge release. There are no more patches coming from us. |
Collaborator
|
Here is the release version: https://github.com/LSSTDESC/Spectractor/releases/tag/v3.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeremyneveu these are the changes from our fork that we discussed on the RFC. Please can you take a look at them and hopefully accept them:
cc/ @erykoff and @mfisherlevine (who wrote these fixes)