Escape backslashes in DotGraph values

[labkey-tchad]

Rationale

We aren't escaping backslashes in our generated DotGraph. This can end up generating invalid DOT syntax.

The actual label in the following DOT snippet is intended to be ,\"^:}}"#)B-d@x.Db&-. We correctly escape the quote but not the backslash:

M27231[label=",\\"^:}}\"#)B-d@x.Db&-", tooltip="Material: ,\\"^:}}\"#)B-d@x.Db&-", etc.]

The parser then decodes the double-backslash and leaves the following quote unescaped:

org.graphper.parser.ParseException: line 4:18 token recognition error at: '^'
	at org.graphper.parser.DotSyntaxErrorListener.syntaxError(DotSyntaxErrorListener.java:40)
	[...]
	at org.labkey.experiment.ExperimentRunGraph.getSvg(ExperimentRunGraph.java:53)
	at org.labkey.experiment.ExperimentRunGraph.renderSvg(ExperimentRunGraph.java:46)

This is a pre-existing defect (reproduced in 25.7) but didn't cause any test failures because we didn't log errors returned by dot execution.

Related Pull Requests

• Replace Graphviz/DOT with a Java implementation #7557

Changes

• Escape backslashes in DotGraph values

[labkey-adam]

Do we have any tests for this?

[labkey-tchad]

Do we have any tests for this?

Not explicitly but SampleTypeDeriveRunProvenanceTest generates random sample names that tend to trigger this error.